Dataset Refactor #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
deepakgopinath
commented
Apr 18, 2021
deepakgopinath
commented
- Base class for Dataset (implements all getters for different caches [ video frame, optic flow, segmentation, gaze data])
- Three Derived classes. [Gaze, Att_Labels, Pairwise Gaze]
- Cleaned up args file (potentially more clean up to happen later on)
- init.py in all folders.
- Simple dataset test script.
|
|
||
| def __getitem__(self, idx): | ||
| """ | ||
| Required getitem() for PyTorch gaze dataset. |
| assert ( | ||
| self.att_awareness_labels_csv_path is not None | ||
| ), "Please provide the full path to the awareness labels csv file" | ||
| df = pd.read_csv( |
There was a problem hiding this comment.
weird to split this over two lines. Prefer the style of # comment prior to code, and code on one line?
There was a problem hiding this comment.
Yep, Will fix this. Prior to code is better.
src/chm/configs/args_file.py
Outdated
| help="filtering used for downsampling optic flow side channel inp [max, avg, median]", | ||
| ) | ||
|
|
||
| ########################## |
src/chm/dataset/dataset_test.py
Outdated
|
|
||
| pairwise_dataset = CognitiveHeatMapPairwiseGazeDataset("train", params_dict) | ||
| pairwise_data_dict = pairwise_dataset[0] # contains data_t, data_tp1 | ||
| import IPython |
There was a problem hiding this comment.
this is called dataset_test, but it's not running a test? maybe it's better to have this as a notebook to illustrate the data dictionary?
There was a problem hiding this comment.
Yes, I will do that towards the end. This was more like a temporary script to test stuff on AWS.
| @@ -0,0 +1,125 @@ | |||
| # Copyright 2021 Toyota Research Institute. All rights reserved. | |||
|
|
|||
| # This file details the field names and some notations used in datasets' getitems for CHM training | |||
There was a problem hiding this comment.
seems like it would be a lot cleaner to have most of this within a single dictionary of constants, not sure it's worth the effort though?
| dest="no_save_model", | ||
| action="store_true", | ||
| default=False, | ||
| help="when set, model saving does not happen. ", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.