[MSW-02C] Inefficient Variable Packing

[cozcan]

MSW-02C: Inefficient Variable Packing

Type	Severity	Location
Gas Optimization		MultiSigWallet.sol:L49-L50, L55

Description:

The Transaction struct of the MultiSigWallet contract has a bool variable as well as address variables that are not grouped together.

Example:

struct Transaction {
  address payable destination;
  address token;
  TokenStandard ts;
  uint tokenId;
  uint value;
  bytes data;
  bool executed;
  uint confirmTimestamp;
  uint txTimestamp;
}

Recommendation:

We advise the bool variable to be relocated either after or before an address variable, ensuring that the Transaction struct is tight-packed and occupies one less storage slot than it presently does.

[cozcan]

The executed boolean variable has been relocated before the destination address, optimizing the storage space of the Transaction struct.

Fixed by the Pull Request 21