Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show joke source URL #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show joke source URL #2

wants to merge 1 commit into from

Conversation

ognjen-petrovic
Copy link
Collaborator

@ognjen-petrovic ognjen-petrovic commented May 24, 2020

It just shows joke's source URL

image

@Tpojka
Copy link
Owner

Tpojka commented Jun 5, 2020

@ognjen-petrovic
Would this too defocus people from app giving them steps to in one hand leave and go to source?
Mostly because it won't give them real URL of concrete joke but rather URL of service.

@ognjen-petrovic
Copy link
Collaborator Author

ognjen-petrovic commented Jun 5, 2020 via email

@Tpojka
Copy link
Owner

Tpojka commented Jun 5, 2020

I will check if icanhasdadjoke is sending some kind of referral link in Slack service that is officially offered on their homepage. If they send only API joke I'd like to continue this way. Just been searching license agreement on their site but I didn't find it. :/
I would rather set their logo if that is possible than link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants