Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent type form and list #62

Closed
2 tasks
atompie opened this issue Nov 29, 2021 · 12 comments · Fixed by #68
Closed
2 tasks

Consent type form and list #62

atompie opened this issue Nov 29, 2021 · 12 comments · Fixed by #68
Assignees
Milestone

Comments

@atompie
Copy link
Collaborator

atompie commented Nov 29, 2021

Endpoints:

Form components:

Use Mui components

"id": , : Hidden
"name": input,
"description": textarea,
"revokable": switch,
"default_value": select[grant|deny]

Styling

Use TuiForm for styling:
https://github.com/Tracardi/tracardi-gui/tree/master/src/components/elements/tui

Example:
https://github.com/Tracardi/tracardi-gui/blob/master/src/components/elements/details/ProfileDetails.js

@atompie atompie added this to the version 0.6.1 milestone Nov 29, 2021
@atompie
Copy link
Collaborator Author

atompie commented Nov 29, 2021

@danjohnson77 Hi Daniel. Would you mind helping us with this task?

You will need an update on backend and frontend to see the new API.

Best.

@danjohnson77
Copy link
Contributor

danjohnson77 commented Nov 29, 2021

@atompie Hi Risto, hope alls well! Just getting back to my desk after traveling last week, happy to take this on! Will update all before starting, thanks!

Also noted the PR format mentioned in the active PR, will follow that standard 👍🏼

@danjohnson77 danjohnson77 self-assigned this Nov 30, 2021
@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

@danjohnson77 thanks Daniel. Have a safe travel :)

@danjohnson77
Copy link
Contributor

danjohnson77 commented Nov 30, 2021

@atompie Just want to confirm you'd like the Consent Types listed using the Properties component, like in Profile Details? Or if not, is there an existing list component you'd like it based on?

@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

@danjohnson77 I'd rather use something else. Could you suggest something?

@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

We do not have a list component for now. Some say that this can be used to build a decent list componet.
https://github.com/bvaughn/react-window

@danjohnson77
Copy link
Contributor

danjohnson77 commented Nov 30, 2021

@atompie If it's just list the title and delete, the Key Value form could work at least as a starting point

For some reason when I go to npm install off the current master branch I'm getting dependency errors, seeing anything like that on your end?

@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

No. We use yarn. Did you make a source update on your fork?

@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

maybe you could delete package.lock

@danjohnson77
Copy link
Contributor

That's why I need the second cup of coffee lol, working now thanks.

You can clone the consent-type branch on my fork and look at /tryout, let me know if that's what you're looking for in terms of the add form.

@atompie
Copy link
Collaborator Author

atompie commented Nov 30, 2021

@danjohnson77 OK. BTW. We opened a slack channel for better communication on none issue related talks would you like to join? https://join.slack.com/t/tracardi/shared_invite/zt-znlomuhd-fatn3qxuI7VO9sBlHk~NhA

@danjohnson77
Copy link
Contributor

@atompie Sounds great, just joined!

atompie pushed a commit that referenced this issue Dec 1, 2021
* added consent type form
* added consent type list
* Reset Tryout.js to previous state
@atompie atompie linked a pull request Dec 2, 2021 that will close this issue
1 task
@atompie atompie closed this as completed Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants