Implement fast slow metrics.

TraceMachina · Sep 9, 2023 · 10d2618 · 10d2618
1 parent 65b8f0e
commit 10d2618
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 0 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/cas/store/BUILD b/cas/store/BUILD
@@ -156,6 +156,7 @@ rust_library(
         "//util:buf_channel",
         "//util:common",
         "//util:error",
+        "//util:metrics_utils",
         "@crate_index//:futures",
     ],
 )

diff --git a/cas/store/fast_slow_store.rs b/cas/store/fast_slow_store.rs
@@ -21,6 +21,7 @@ use futures::{join, FutureExt};
 use buf_channel::{make_buf_channel_pair, DropCloserReadHalf, DropCloserWriteHalf};
 use common::DigestInfo;
 use error::{make_err, Code, Error, ResultExt};
+use metrics_utils::Registry;
 use traits::{StoreTrait, UploadSizeInfo};
 
 // TODO(blaise.bruer) This store needs to be evaluated for more efficient memory usage,
@@ -239,4 +240,11 @@ impl StoreTrait for FastSlowStore {
     fn as_any(self: Arc<Self>) -> Box<dyn std::any::Any + Send> {
         Box::new(self)
     }
+
+    fn register_metrics(self: Arc<Self>, registry: &mut Registry) {
+        let fast_store_registry = registry.sub_registry_with_prefix("fast");
+        self.fast_store.clone().register_metrics(fast_store_registry);
+        let slow_store_registry = registry.sub_registry_with_prefix("slow");
+        self.slow_store.clone().register_metrics(slow_store_registry);
+    }
 }
diff --git a/gencargo/fast_slow_store/Cargo.toml b/gencargo/fast_slow_store/Cargo.toml
@@ -28,3 +28,4 @@ config = { workspace = true }
 buf_channel = { workspace = true }
 common = { workspace = true }
 error = { workspace = true }
+metrics_utils = { workspace = true }