Skip to content

Commit

Permalink
Give flaky memory store test more wiggle room (#448)
Browse files Browse the repository at this point in the history
This is known to cause issues, especially for sanitized tests.
Additional testing on MacOS showed that this needs to be at least 25%,
so make it 30% to be on the safe side.
  • Loading branch information
aaronmondal committed Dec 6, 2023
1 parent c5c440a commit ab0f1ac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion native-link-store/tests/memory_store_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ mod memory_store_tests {
async fn ensure_full_copy_of_bytes_is_made_test() -> Result<(), Error> {
// Arbitrary value, this may be increased if we find out that this is
// too low for some kernels/operating systems.
const MAXIMUM_MEMORY_USAGE_INCREASE_PERC: f64 = 1.2; // 20% increase.
const MAXIMUM_MEMORY_USAGE_INCREASE_PERC: f64 = 1.3; // 30% increase.

let store_owned = MemoryStore::new(&native_link_config::stores::MemoryStore::default());
let store = Pin::new(&store_owned);
Expand Down

0 comments on commit ab0f1ac

Please sign in to comment.