Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S3 store closes connections early #304

Closed
allada opened this issue Oct 3, 2023 · 0 comments · Fixed by #341
Closed

S3 store closes connections early #304

allada opened this issue Oct 3, 2023 · 0 comments · Fixed by #341

Comments

@allada
Copy link
Member

allada commented Oct 3, 2023

There's a bug in the S3 store where if the digest is small it will upload it as a one-shot for efficiency, however it requires the size to be known. Once that exact size of bytes is received it drops stream causing an upstream error to the sender.
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Oct 25, 2023
@aaronmondal
Add optimistic channels
b02cfcc 
This variation on make_buf_channel_pair omits the EOF check. This works
around the fact that S3 drops connections as soon as all data is sent or
received.

Fixes TraceMachina#304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Oct 25, 2023
@aaronmondal
Add optimistic channels
d8bf8c0 
This variation on make_buf_channel_pair omits the EOF check. This works
around the fact that S3 drops connections as soon as all data is sent or
received.

Fixes TraceMachina#304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
@aaronmondal aaronmondal mentioned this issue Oct 25, 2023
Merged
aaronmondal added a commit to aaronmondal/nativelink that referenced this issue Oct 26, 2023
@aaronmondal
Add ability to ignore EOF check for writers
2137225 
Work around the fact that S3 drops connections as soon as all data is
sent or received.

Fixes TraceMachina#304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
aaronmondal added a commit that referenced this issue Oct 26, 2023
@aaronmondal
Add ability to ignore EOF check for writers (#341)
979f941 
Work around the fact that S3 drops connections as soon as all data is
sent or received.

Fixes #304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
blakehatch pushed a commit to blakehatch/nativelink that referenced this issue Nov 14, 2023
@aaronmondal @blakehatch
Add ability to ignore EOF check for writers (TraceMachina#341)
0f5813a 
Work around the fact that S3 drops connections as soon as all data is
sent or received.

Fixes TraceMachina#304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
blakehatch pushed a commit to blakehatch/nativelink that referenced this issue Nov 21, 2023
@aaronmondal @blakehatch
Add ability to ignore EOF check for writers (TraceMachina#341)
73b3ab2 
Work around the fact that S3 drops connections as soon as all data is
sent or received.

Fixes TraceMachina#304 and fixes the same issue for non-oneshot cases where a
similar issue occurred as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add optimistic channels aaronmondal/nativelink
1 participant
@allada