Update README.md for AWS Terraform Deployment #608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add minor instruction to have AWS CLI IAM user configured
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
allada
approved these changes
Jan 16, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 LGTMs obtained
|
@allada This PR was flagged as "This wasn't checked by CI before merging". I'm surprised that this was mergeable without running any CI jobs. Even if it's not really a code change we should probably have at least one job (like a markdown format job or something) running on PRs like this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add minor instruction to have AWS CLI IAM user configured. I started setting up nativelink from a new dev machine and forgot to setup my AWS credentials before running terraform. Figured a small reminder here couldn't hurt!
Checklist
bazel test //...passes locallygit amendsee some docsThis change is