You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The RBE protocol specifies that if the first message in a stream
has the resource_name set all subsequent messages do not need to
have it set. With this patch we now honor that requirement for
GrpcStore hotpath.
closes: TraceMachina#745
The RBE protocol specifies that if the first message in a stream
has the resource_name set all subsequent messages do not need to
have it set. With this patch we now honor that requirement for
GrpcStore hotpath.
closes: TraceMachina#745
The RBE protocol specifies that if the first message in a stream
has the resource_name set all subsequent messages do not need to
have it set. With this patch we now honor that requirement for
GrpcStore hotpath.
closes: #745
Discovered here:
https://nativelink.slack.com/archives/C06758HJQF8/p1709975017849379
We currently violate spec, because we require every message of a GRPC write stream have the
resource_name
set and the spec explicitly states this is not required:https://github.com/googleapis/googleapis/blob/4ce0ff67a3d4509be641cbe47a35844ddc1268fc/google/bytestream/bytestream.proto#L127
This is client dependent and bazel is one of the clients that only sets it on the first message and leaves it
None
for all further chunks.Offending code:
nativelink/nativelink-store/src/grpc_store.rs
Line 191 in 3e6f154
The text was updated successfully, but these errors were encountered: