Use Blake3 hasher for computing the action message #395
Conversation
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on @blakehatch)
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @allada)
cas/scheduler/action_messages.rs line 215 at r1 (raw file):
execution_policy: None, // Not used in the worker. results_cache_policy: None, // Not used in the worker. digest_function: digest_function::Value::Sha256.into(),
Change to Blake3
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @blakehatch)
cas/scheduler/action_messages.rs line 215 at r1 (raw file):
Previously, blakehatch (Blake Hatch) wrote…
Change to Blake3
This cannot be blake3 yet. This PR is only changing an internal hash that is nothing to do with the protocol. The next PR is going to change the protocol parts to use blake3.
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Migrate the internal hashing algorithm used to compute the hash for the action when sending to/from the worker/scheduler. This is a minor optimization to move away from Sha256.
allada
force-pushed
the
action-info-hash-to-use-blake3
branch
from
95fff8f
to
ad04655
Compare
There was a problem hiding this comment.
Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Dismissed @blakehatch from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @blakehatch)
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes #395
Migrate the internal hashing algorithm used to compute the hash for the action when sending to/from the worker/scheduler. This is a minor optimization to move away from Sha256.
Fully support Blake3 digest upload format. This can increase performance significantly for cases where hashing files is a bottleneck. closes TraceMachina#395
Migrate the internal hashing algorithm used to compute the hash for the action when sending to/from the worker/scheduler. This is a minor optimization to move away from Sha256.
This change is