Publish container images #443
Conversation
There was a problem hiding this comment.
+@allada +@MarcusSorealheis +@adam-singer +@blakehatch
You can ignore the first commit as that'll be "rebased away" after #442.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r2.
Reviewable status: 5 of 8 files reviewed, 2 unresolved discussions (waiting on @aaronmondal, @adam-singer, @blakehatch, and @MarcusSorealheis)
README.md line 47 at r2 (raw file):
# Verify the signature cosign verify ghcr.io/TraceMachina/native-link:${LATEST} \ --certificate-identity=https://github.com/TraceMachina/native-link/.github/workflows/image.yaml@refs/heads/main \
What happens if main is updated but the latest github action has not yet finished uploading? Won't this cause issues?
aaronmondal
force-pushed
the
release-container
branch
from
7f9309e
to
e314f16
Compare
There was a problem hiding this comment.
Reviewable status: 4 of 8 files reviewed, 2 unresolved discussions (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
README.md line 9 at r1 (raw file):
Previously, MarcusSorealheis (Marcus Eagan) wrote…
Unix-based
Done.
README.md line 47 at r2 (raw file):
Previously, allada (Nathan (Blaise) Bruer) wrote…
What happens if main is updated but the latest github action has not yet finished uploading? Won't this cause issues?
I wouldn't say that it's too big of an issue, but it can surely be inconvenient if the image is unexpectedly not ready immediately. I've added a comment above and also added a "production" variant that can be used to fully pins the image.
There was a problem hiding this comment.
Dismissed @MarcusSorealheis from a discussion.
Reviewable status: 4 of 8 files reviewed, 1 unresolved discussion (waiting on @adam-singer, @allada, @blakehatch, and @MarcusSorealheis)
README.md line 9 at r1 (raw file):
Previously, aaronmondal (Aaron Siddhartha Mondal) wrote…
Done.
Done
aaronmondal
force-pushed
the
release-container
branch
2 times, most recently
from
28b914a
to
131775e
Compare
Introduce signed, fully reproducible container images that are created on pushes to main and published via GitHub packages.
aaronmondal
force-pushed
the
release-container
branch
from
131775e
to
cf8709e
Compare
Introduce signed, fully reproducible container images that are created
on pushes to main and published via GitHub packages.
This change is