[Breaking] Standardize configurations so they are all lower case #461
Conversation
There was a problem hiding this comment.
cc: @chrisstaite-menlo (We decided to always make everything lower case in the config in the hopes to future-proof breaking changes. This will break current users though).
Reviewable status: 0 of 14 files reviewed, all discussions resolved (waiting on @adam-singer)
There was a problem hiding this comment.
I assume existing config files in the repo also need to be changed?
Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @allada)
To make the configuration more standardized we have moved all config properties that might be set in the json to be lower case. Before we had a mix of sometimes lower case and sometimes upper. By making this a hard rule, we simplify a lot of this thought.
allada
force-pushed
the
all-configs-to-lower-case
branch
from
a0ba2c8
to
7d1f010
Compare
There was a problem hiding this comment.
I think this is ready yo land.
Reviewable status: 0 of 41 files reviewed, all discussions resolved (waiting on @adam-singer)
allada
changed the title
There was a problem hiding this comment.
Reviewed 41 of 41 files at r2, all commit messages.
Reviewable status:
To make the configuration more standardized we have moved all config properties that might be set in the json to be lower case.
Before we had a mix of sometimes lower case and sometimes upper. By making this a hard rule, we simplify a lot of this thought.
This change is