ENG-36756: add logging config #18
Conversation
kaushal02
requested review from
tim-mwangi,
ryanericson,
varkey98 and
puneet-traceable
|
Hey @kaushal02 generated code at gen/go/v1/config.pb.go should be checked into the PR. |
| // logging level. Allowed values are trace, debug, info, warn, error, critical. | ||
| google.protobuf.StringValue level = 2; | ||
| // if logging mode is file, provide this additional configuration | ||
| LogFileConfig log_file = 3; |
There was a problem hiding this comment.
Was wondering if we should rename this to log_rotation so that its consistent with TPA and eBPF? https://github.com/Traceableai/traceable-agent/blob/056b2578d7b24a0c643e99b29e2192de8ab9a2cb/proto/config/common/v1/config.proto#L135
There was a problem hiding this comment.
I feel that rotation is separate to file logging. that way file name is a separate config and log_rotation is separate.
There was a problem hiding this comment.
like
logging:
- level
- mode
- filename
and
log_rotation:
- max_file_size
- max_file_count
?
There was a problem hiding this comment.
Current config looks good to me.
| // logging mode. Allowed values are none, stdout, file. | ||
| google.protobuf.StringValue mode = 1; | ||
| // logging level. Allowed values are trace, debug, info, warn, error, critical. | ||
| google.protobuf.StringValue level = 2; |
There was a problem hiding this comment.
@kaushal02 can we use enum instead of strings?
There was a problem hiding this comment.
didn't realise that was an option. Updating it now, thanks :)
https://traceableai.atlassian.net/browse/ENG-36756