ENG-38732: adding metrics config #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varkey98
requested review from
ryanericson,
shashank11p and
puneet-traceable
added 2 commits
February 19, 2024 19:31
shashank11p
reviewed
Feb 19, 2024
| // set the frequency at which endpoint level metrics should be printed. Examples are '1s', '2m', '3h'. Default value is 30m | ||
| google.protobuf.StringValue frequency = 2; | ||
| // set the max number of endpoints to track | ||
| google.protobuf.Int32Value max_endpoints = 3; |
There was a problem hiding this comment.
How will this work? The 1st maxEndpoints number of endpoints seen in a TA will be tracked?
| message EndpointMetricsConfig { | ||
| // set this flag to enable endpoint level metrics | ||
| google.protobuf.BoolValue enabled = 1; | ||
| // set the frequency at which endpoint level metrics should be printed. Examples are '1s', '2m', '3h'. Default value is 30m |
There was a problem hiding this comment.
right now we just print the stats in the log
| @@ -16,6 +16,7 @@ message AgentConfig { | |||
| // javaagent has the configs specific to javaagent | |||
| Javaagent javaagent = 7; | |||
| LogConfig logging = 8; | |||
| MetricsConfig metrics_config = 9; | |||
There was a problem hiding this comment.
Which metrics will be covered in this metrics_config?
There was a problem hiding this comment.
For now, we just have sampling metrics
shashank11p
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Metrics config. As of now only sampling metrics is captured and they're just being print in the logs