Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(engine): Dynamically register UDFs in DSLActivities #176

Merged
merged 1 commit into from
Jun 16, 2024
Merged

feat(engine): Dynamically register UDFs in DSLActivities #176

merged 1 commit into from
Jun 16, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jun 16, 2024 •
edited
Loading

Features

  • Instead of displaying run_udf for every function, dynamically wrap each UDF in a Temporal activity and register it with workers.
    • In the UDF key we replace . with __. e.g. ns.subns.method_name -> ns__subns__method_name

Remarks

  • Improve workflow observability
  • Before we start a worker, generate temporal activity wrappers for all registered UDFs so that they show up as activity types in the Temporal UI

Screens

image

Testing

  • All workflow tests passing

@github-actions github-actions bot added engine Improvements or additions to the workflow engine enhancement New feature or request labels Jun 16, 2024
@daryllimyt daryllimyt self-assigned this Jun 16, 2024
@daryllimyt daryllimyt force-pushed the feat/dsl/better-udf-run-names branch from 7b2934b to 8172f8e Compare June 16, 2024 22:51
topher-lo
topher-lo approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topher-lo topher-lo merged commit b7af066 into main Jun 16, 2024
6 checks passed
@topher-lo topher-lo deleted the feat/dsl/better-udf-run-names branch June 16, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo topher-lo approved these changes

Assignees

@daryllimyt daryllimyt

Labels
engine Improvements or additions to the workflow engine enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daryllimyt @topher-lo