Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incorrect reference to all nodes instead of action nodes only #178

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fix: Incorrect reference to all nodes instead of action nodes only #178

merged 2 commits into from
Jun 17, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Jun 17, 2024 •
edited
Loading

Changes

  • Add better error message for empty graph
  • Use RFGraph.action_nodes() instead of RFGraph.nodes to perform validation

Testing

  • Verified that workflow that was created headless can be edited in the GUI, then committed back as a definition. Cross referenced this with database

@daryllimyt daryllimyt self-assigned this Jun 17, 2024
@github-actions github-actions bot added engine Improvements or additions to the workflow engine fix Bug fix frontend Improvements or additions to the frontend labels Jun 17, 2024
@daryllimyt daryllimyt added engine Improvements or additions to the workflow engine and removed frontend Improvements or additions to the frontend engine Improvements or additions to the workflow engine labels Jun 17, 2024
@github-actions github-actions bot added the frontend Improvements or additions to the frontend label Jun 17, 2024
@daryllimyt daryllimyt merged commit 64440dc into main Jun 17, 2024
4 checks passed
@daryllimyt daryllimyt deleted the fix/gui-workflow-commit branch June 17, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo Awaiting requested review from topher-lo

Assignees

@daryllimyt daryllimyt

Labels
engine Improvements or additions to the workflow engine fix Bug fix frontend Improvements or additions to the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@daryllimyt