Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui+engine): Extend secrets manager #36

Merged
merged 4 commits into from Apr 12, 2024
Merged

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Apr 12, 2024

Changes

  • Update the Secret schema so that each can contain an arbitrary number of key-value pairs. For example, you could define a 'github_secret' that can contain 'GH_ACCESS_TOKEN', 'GH_USERNAME' etc. This makes supporting complex auth/secret types (e.g. OAuth) easier down the line.
  • Update the encryption corresponding to the above change. We encrypt the entire keys list as a JSON object, and store the encrypted secret as bytes (same as before).
  • Update the credentials page in the settings to reflect the schema changes. The creation wizard has also been updated to accept >=1 key-value pairs.
  • Update templated secret parsing in the execution engine and updated tests.

Testing

  • Ran updated tests, test_templates.py tests passing.
  • Manual workflow run which calls URLScan API with successful console output

Closes #32

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracecat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 3:44am

@topher-lo topher-lo merged commit c8e1f11 into main Apr 12, 2024
6 of 7 checks passed
@topher-lo topher-lo deleted the feat/extend-secrets-manager branch April 12, 2024 04:01
topher-lo pushed a commit that referenced this pull request May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engine enhancement New feature or request frontend
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Revamp secrets manager to accept arbitrary objects
2 participants