Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui+engine): Improve case management [2/N] #66

Merged
merged 13 commits into from Apr 20, 2024
Merged

feat(ui+engine): Improve case management [2/N] #66

merged 13 commits into from Apr 20, 2024

Conversation

daryllimyt
Copy link
Contributor

@daryllimyt daryllimyt commented Apr 19, 2024 •
edited

Changes

  • Remove support for autocompleting action and context. context should be populated during the workflow, and action should be intentional (though these are subject to change)
  • Update autocomplete to complete for tags only. These include tracecat default mitre tags (see db init) and can be extended include user defined tags (TODO)
  • Refactor cases to use list[Model] types - allows for duplicate tags with different values (e.g. for mitre labelling)
  • Remove null states for case types - easier to handle in zod and leads to cleaner pydantic serde
  • Remove metrics banner
  • Minor case table styles update
  • Some refactoring/simplification of code

Closes #70

@daryllimyt daryllimyt self-assigned this Apr 19, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 19, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tracecat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2024 5:17am

@github-actions github-actions bot added engine enhancement New feature or request frontend labels Apr 19, 2024
@daryllimyt daryllimyt mentioned this pull request Apr 19, 2024
Open
41 tasks
@daryllimyt daryllimyt marked this pull request as ready for review April 20, 2024 05:18
topher-lo
topher-lo approved these changes Apr 20, 2024
View reviewed changes
Copy link
Contributor

@topher-lo topher-lo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@topher-lo topher-lo merged commit a341de7 into main Apr 20, 2024
9 checks passed
@topher-lo topher-lo deleted the feat/better-case-management-2 branch April 20, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topher-lo topher-lo topher-lo approved these changes

Assignees

@daryllimyt daryllimyt

Labels
engine enhancement New feature or request frontend
Projects
Alpha 2.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update autocomplete for tags only
2 participants
@daryllimyt @topher-lo