Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ONNX import issue: ceil_mode is not supported in avg_pool1d_config() #2132

Open
SimonBrandner opened this issue Aug 8, 2024 · 3 comments
Open

ONNX import issue: ceil_mode is not supported in avg_pool1d_config() #2132

SimonBrandner opened this issue Aug 8, 2024 · 3 comments
Labels
blocked Should not be tackled right now enhancement Enhance existing features help wanted Extra attention is needed

Comments

@SimonBrandner
Copy link 

ERROR burn_import::logger: PANIC => panicked at /home/simon/.cargo/git/checkouts/burn-178c6829f420dae1/d770b1f/crates/burn-import/src/onnx/op_configuration.rs:374:9:
ceil_mode is not supported

Link to model: drive.google.com/file/d/1E6fNKzGE3_JhEokgqqHDqJxwqw3UUku9/view?usp=drive_link
@SimonBrandner SimonBrandner mentioned this issue Aug 8, 2024
Open
6 tasks
@antimora
Copy link
Collaborator

antimora commented Aug 8, 2024 •
edited
Loading

This requires enhancement to Burn's average pool implementation before we can take on ONNX

@antimora antimora added enhancement Enhance existing features help wanted Extra attention is needed labels Aug 8, 2024
@mepatrick73
Copy link
Contributor

This probably requires rewriting the pooling tensor operations in CubeCL. They are currently written in "pseudo-assembly" and I don't see a good reason to try and maintain that version.

@mepatrick73 mepatrick73 mentioned this issue Aug 8, 2024
Open
@mepatrick73 mepatrick73 added the blocked Should not be tackled right now label Aug 8, 2024
@mepatrick73
Copy link
Contributor

I'm locking this behind #2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Should not be tackled right now enhancement Enhance existing features help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antimora @SimonBrandner @mepatrick73