Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing footer copyright in home page #25

Closed
zemien opened this issue Dec 30, 2018 · 3 comments
Closed

Missing footer copyright in home page #25

zemien opened this issue Dec 30, 2018 · 3 comments

Comments

@zemien
Copy link

zemien commented Dec 30, 2018

The footer copyright message is not appearing in the home page. It works in all other pages. You can see that on the demo site https://themes.gohugo.io/theme/hermit/

@Track3
Copy link
Owner

Track3 commented Dec 31, 2018

Home page didn't use the default footer template, because I don't want the home page footer to be too long. This is more like a personal preference. If you like, add {{ .Site.Params.footerCopyright | safeHTML }} inside layouts/index.html#L23

@zemien
Copy link
Author

zemien commented Dec 31, 2018

Fair enough. What are your thoughts about making it a configurable on/off element? I want to avoid customizing the theme directly because it will complicate me pulling new changes in the future.

I can raise a PR for this if you're open to the idea.

Oh, I've migrated my WordPress blog to Hugo using your theme and it's looking good! Coder on the Frontline

Track3 added a commit that referenced this issue Jan 1, 2019
@Track3
Copy link
Owner

Track3 commented Jan 1, 2019

To make it simple, it's fine to display footer copyright in home page using config. The homepage footer is part of layouts/index.html, it's more likely to get updated. but the general footer template is a partial, it can be easily overrode.

@Track3 Track3 closed this as completed Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants