themeColor isn't use in the background-color

[hirefrank]

Should it be? I don't see it being passed into the scss as I'd expect.

I just see it in the layouts/_default/baseof.html:

{{- with .Site.Params.themeColor }}
<meta name="theme-color" content="{{.}}">
<meta name="msapplication-TileColor" content="{{.}}">
{{- end }}

I created a workaround in the layouts/partials/extra-head.html:

{{- with .Site.Params.themeColor }}
<style>
html {background-color: {{.}};}
</style>
{{- end }}

Thanks for creating the theme!

[Track3]

themeColor in the config is designed to only affect "theme-color" meta tags, just because people may not want to set this property or they want to use a different color from the page background. If you want to change the background color, you may want to change other color as well, so the better way is to override theme's assets/scss/_predefined.scss, you can just copy this file to site's root (keep the same ralative path), and then edit those color variables.

[hirefrank]

Excellent! Thanks!

…

On Mon, Apr 8, 2019 at 1:06 AM Track3 ***@***.***> wrote: themeColor in the config is designed to only affect "theme-color" meta tags, just because people may not want to set this property or they want to use a different color from the page background. If you want to change the background color, you may want to change other color as well, so the better way is to override theme's assets/scss/_predefined.scss, you can just copy this file to site's root (keep the same ralative path), and then edit those color variables. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#58 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALLdqAWF7-Yrsec5pHVnUF3tYshFrqgks5veviZgaJpZM4cgd4F> .

-- Frank Harris hirefrank.com / @hirefrank <http://twitter.com/hirefrank>