Important: fix offsets of compressed messageSet #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…generates millions of tcp connections.
. support for v1, v2, v3 version of Fetch API . support for v1 version of messages . support for v1, v2 version of Produce API . support for timestamp in messages
Change-Id: Ie1104395359f8a1f7958f22a00536b54ae0e3e89
Change-Id: I622e484c52431719f1eedc9655180fb1ddbb76c0
Change-Id: I51c3a4892846a327fb13488e320760793adc35ab
Change-Id: I8ba3391c980ed04a51ecd2ff0d628cc3916075e5
Change-Id: Ie461f89d3f6d217cf27786d32e04f33229bce3ab
Change-Id: I72d67662e1f83d0ec5518b5fe29509e95200ce82
Change-Id: I40516057b2a625438005953fc711cebbf14d5332
Change-Id: Id9cfd41b5277d0f00604dd63711b9f7207203018
Change-Id: I022707772c1e3df56d215f66986e295eed70d66a
Change-Id: Iac77a69ef2d9e04cce2536a3731bd7a1a775c1a7
Change-Id: I907d5448061c0ebe7a9aac55c0c0ba28734c3643
. support for v1, v2, v3 version of Fetch API . support for v1 version of messages . support for v1, v2 version of Produce API . support for timestamp in messages
. fixed messagesets parsing, now we don't need to keep the api version around, we use the MagicByte to find out the message format version . various minor fix
. fixed some typos
…s, there will be a lot of iteration, receiving data. It should not be considered as a retry attempt, as we received some data. So this change decrements retries so that it's not considered as a failed attempt
When a request is done, it may be tried on different brokers in cas of failing brokers. Either the api version is enforced when the request was created, or it is detected against the broker used. However, the version should be detected again when we swtich broker. It was not the case before, now it is.
store the api versions inside the IO cache, so that it's removed/updated whenever needed via _update_metadata.
…, the param list would be inbalanced, and very wrong value could be set. It's now more sane
…when checking if enough data is there for a full message
…e it's compressed, is the offset of the wrapping message, and not the inner offset
asolovey
approved these changes
Jun 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the offset of the decoded messageSet is correct, when the messageSet was compressed.