Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tab-indexes for recurring todo form #128

Merged
merged 1 commit into from Dec 4, 2012

Conversation

dnrce
Copy link
Member

@dnrce dnrce commented Dec 1, 2012

This issue number may also refer to the older ticket #128, now #1595.

Using the natural tab order makes the Create and Cancel buttons accessible.

Fixes #1371

@lrbalt
Copy link
Member

lrbalt commented Dec 2, 2012

I'm not sure I like this. We added the tabindex for a reason, mostly to fix tabbing in the edit form while the new rec todo form was on the page too. Please test (use) this change to make sure all works well for the new rec todo use case and the edit rec todo use case

Using the natural tab order makes the Create and Cancel buttons accessible.

Fixes TracksApp#1371
@dnrce
Copy link
Member Author

dnrce commented Dec 3, 2012

The "new" form and the "edit" form both tab correctly for me in Firefox 17 and Chromium 22. What do you mean by "on the page too?" Is there some way to have them display at the same time that I'm overlooking?

(Actually, the edit form had the same accessibility problem which was fixed by removing the tabindexes there, too. I just updated the commit.)

@maddentim, could you please test this change, too?

@maddentim
Copy link

Yes, this worked for me as well in both the edit and new forms. I tested it in chrome 23 and chromium 22 on ubuntu and on my windows vm it worked in ie8 and ff17. I can test later on an ie9 on another machine, but I would be surprised if it regressed from ie8... I think we are good to go here.

@mattr-
Copy link
Member

mattr- commented Dec 4, 2012

Thanks for the testing!

mattr- added a commit that referenced this pull request Dec 4, 2012
Remove tab-indexes for recurring todo form
@mattr- mattr- merged commit 109da4f into TracksApp:master Dec 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants