Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort containers #1823

Closed
wants to merge 11 commits into from
Closed

Sort containers #1823

wants to merge 11 commits into from

Conversation

C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Apr 14, 2015

Sort containers in JavaScript, for example when updating an action or creating a new one. This fixes #256.

@C-Otto
Copy link
Contributor Author

C-Otto commented Apr 14, 2015

This only works after re-rendering the todo partials. Any idea how to enforce this once?

@C-Otto
Copy link
Contributor Author

C-Otto commented Apr 15, 2015

This does not sort actions when they get unblocked (pending to active). I will work on it.

@C-Otto C-Otto closed this Apr 15, 2015
@C-Otto C-Otto reopened this Apr 16, 2015
@C-Otto
Copy link
Contributor Author

C-Otto commented Apr 16, 2015

I found some more places where we need to sort, this should cover about everything (feel free to tell me if I missed anything).

The JavaScript code has a few problems, and I might be looking into that soon. It seems we often try to change the contents of some action's div using .html(), which effectively adds a div inside the new div (both sharing the same id). Using replaceWith() might be the way to go, instead.

@C-Otto C-Otto closed this Apr 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

next actions with sensitive due-date doesn't automatically sorted with Ajax
1 participant