Convert tracks to use Bundler for gem resolution #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the Gemfile and Gemfile.lock files used to specify the dependencies of the app. The Gemfile specifies the dependencies and the Gemfile.lock is a snapshot of the dependencies. If the Gemfile changes, then Bundler will look at the differences between the Gemfile and the Gemfile.lock to determine what other gems to install or upgrade
Bundler allows us to specify the exact versions of gems which eliminates the need for vendoring gems (IMO)
The default version of actionwebservice removes wsdl_service_name. The dejan/actionwebservice repository from git is a fork of the datanoise repository that we were using that has the gemspec fixed to not use a specific version of Rails.
Fixes the errors I was seeing when trying to run the unit tests
Bundler does a better job of manage dependencies and is used by default in Rails 3 so this will move Tracks a bit closer towards a Rails 3 conversion.
Since we're not explictly requiring datanoise-actionwebservice anymore, we need to modify this to match what we are using.
There were several places where newer versions of gems were being pulled. Those newer versions were breaking the functional tests and the cucumber features. Go back to known working versions of the gems that were causing failures
With rake 0.8.7, rake/rdoctask isn't deprecated and actually works, so use that.
Since Bundler allows to specify exactly what versions of gems we need, the vendored version isn't needed anymore.
Apparently this I missed this when I cleaned up the other frozen gems
|
is a cleanup of the config.gem lined in environment.rb possible after migrating to bundler |
|
The Bundler docs don't mention anything about being able to remove those config.gem lines so I didn't try. I'll dig into this a little bit and find out. |
|
you can remove them as they are no longer needed. Furthermore you should be able to relax a some of the version constraints (also see my Gemfile for reference) and why do you need rubyforge (as it often seems outdated anyway)? |
|
I can't find the time right now to test. I'll merge anyway and we will see :-) |
lrbalt
added a commit
that referenced
this pull request
Aug 27, 2011
Convert tracks to use Bundler for gem resolution
This was referenced Jun 25, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue number may also refer to the older ticket #5, now #1472.
This set of changes converts tracks from using Rails 2.3.x own gem management to using Bundler for gem management. This provides two benefits in my opinion: