MIDI Click: Ensured clock messages are sent even if the device is not…

… being used in an Edit
Tracktion · May 11, 2023 · bea8f8d · bea8f8d
1 parent 4b8cb80
commit bea8f8d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/modules/tracktion_engine/playback/devices/tracktion_MidiOutputDevice.h b/modules/tracktion_engine/playback/devices/tracktion_MidiOutputDevice.h
@@ -47,6 +47,7 @@ class MidiOutputDevice   : public OutputDevice
     void flipSendingTimecode();
 
     void setSendControllerMidiClock (bool b) noexcept   { sendControllerMidiClock = b; }
+    bool isSendingControllerMidiClock() const noexcept  { return sendControllerMidiClock; }
 
     //==============================================================================
     void fireMessage (const juce::MidiMessage&);

diff --git a/modules/tracktion_engine/playback/graph/tracktion_EditNodeBuilder.cpp b/modules/tracktion_engine/playback/graph/tracktion_EditNodeBuilder.cpp
@@ -1578,6 +1578,24 @@ std::unique_ptr<tracktion::graph::Node> createNodeForEdit (EditPlaybackContext&
         }
     }
 
+    // Add deviceNodes for any devices only being used by the MIDI clock or MTC
+    for (int i = edit.engine.getDeviceManager().getNumMidiOutDevices(); --i >= 0;)
+    {
+        if (auto device = edit.engine.getDeviceManager().getMidiOutDevice (i))
+        {
+            const bool isSendingMidi = device->isSendingClock()
+                                        || device->isSendingTimecode()
+                                        || device->isSendingControllerMidiClock();
+
+            if (! isSendingMidi)
+                continue;
+
+            auto& trackNodeVector = deviceNodes[device];
+            juce::ignoreUnused (trackNodeVector);
+            // We don't need to add anything to the vector, just ensure the device is in the map
+        }
+    }
+
 
     auto outputNode = std::make_unique<tracktion::graph::SummingNode>();