Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with setup instructions in README #5

Open
hndmrsh opened this issue Apr 5, 2019 · 1 comment
Open

Issues with setup instructions in README #5

hndmrsh opened this issue Apr 5, 2019 · 1 comment

Comments

@hndmrsh
Copy link
Contributor

hndmrsh commented Apr 5, 2019

The installation instructions in the README are incomplete. I encountered the following issues when trying to add Plunge to my project:

  • The repositories block is missing from the buildscript section
  • The kotlinx-serialization dependency requires a Kotlin version > 1.3.20
  • The kotlinx-serialization repository is missing for the plugin
  • The line Uri.parse(getIntent().getData()) should just be intent.data (as getData() returns a Uri already)
@jamiesanson
Copy link
Contributor

The repositories block and Uri parsing is an easy fix. IMO we should remove kotlinx-serialization and replace it with something available in JCenter. Moshi is likely the smallest drop-in replacement for this. I'll whip up another issue for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants