fix: add implementation event (Open-Attestation#143)

TradeTrust · Nov 25, 2022 · ce9c8c0 · ce9c8c0
1 parent be9e1d0
commit ce9c8c0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/contracts/utils/TDocDeployer.sol b/contracts/utils/TDocDeployer.sol
@@ -15,6 +15,8 @@ contract TDocDeployer is OwnableUpgradeable, UUPSUpgradeable, TDocDeployerErrors
     bytes params
   );
 
+  event AddImplementation(address indexed implementation, address indexed titleEscrowFactory);
+
   // mapping: implementation => title escrow factory
   mapping(address => address) public implementations;
 
@@ -48,6 +50,8 @@ contract TDocDeployer is OwnableUpgradeable, UUPSUpgradeable, TDocDeployerErrors
       revert ImplementationAlreadyAdded();
     }
     implementations[implementation] = titleEscrowFactory;
+
+    emit AddImplementation(implementation, titleEscrowFactory);
   }
 
   function removeImplementation(address implementation) external onlyOwner {

diff --git a/test/TDocDeployer.test.ts b/test/TDocDeployer.test.ts
@@ -105,6 +105,14 @@ describe("TDocDeployer", async () => {
         expect(res).to.equal(fakeTitleEscrowFactory);
       });
 
+      it("should emit AddImplementation when add implementation", async () => {
+        const tx = await deployerContractAsNonOwner.implementations(implContract.address);
+
+        expect(tx)
+          .to.emit(deployerContract, "AddImplementation")
+          .withArgs(implContract.address, fakeTitleEscrowFactory);
+      });
+
       it("should not allow adding an already added implementation", async () => {
         const tx = deployerContractAsOwner.addImplementation(implContract.address, fakeTitleEscrowFactory);