Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add mention notification #2459

Merged
merged 2 commits into from Apr 2, 2024
Merged

Conversation

HerrLevin
Copy link
Member

No description provided.

@@ -16,7 +17,8 @@ class MentionHelper
private bool $isCreating;

public function __construct(Status $status, string $body = null) {
$this->status = $status;
$this->status = $status;
$status->load('mentions', 'mentions.mentioned');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$status->load('mentions', 'mentions.mentioned');
$status->load('mentions.mentioned');

mentions wird bereits von dem folgenden Attribut mitgeladen.

@MrKrisKrisu
Copy link
Member

@jheubuch @marhei @vainamov Falls für euch relevant: Es gibt nach dem PR einen neuen Typ von Notification UserMentioned.

@HerrLevin HerrLevin added this pull request to the merge queue Apr 2, 2024
Merged via the queue into develop with commit 23aa415 Apr 2, 2024
10 checks passed
@HerrLevin HerrLevin deleted the dev-lb/mention_notification branch April 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants