Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Issue MediaType #6

Merged
merged 6 commits into from Oct 17, 2018
Merged

Add Issue MediaType #6

merged 6 commits into from Oct 17, 2018

Conversation

VincentRbbmnd
Copy link
Collaborator

No description provided.

@VincentRbbmnd VincentRbbmnd added the 💎 feature New feature label Oct 16, 2018
@VincentRbbmnd VincentRbbmnd self-assigned this Oct 16, 2018
SleeplessByte
SleeplessByte reviewed Oct 16, 2018
View reviewed changes
ruby/lib/trailer_vote/media_types/issue.rb Outdated

end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF newline

ruby/test/trailer_vote/fixtures/application/vnd.trailervote.issue.v1.create+json Outdated
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF newline

ruby/lib/trailer_vote/media_types/issue.rb Show resolved Hide resolved
ruby/test/trailer_vote/media_types/issue_test.rb Outdated
end
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EOF newline

SleeplessByte
SleeplessByte requested changes Oct 16, 2018
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want to add a link to self, because then you don't need to update this media type to add update and destroy via API capability.

You also need to add the issues link to the configuration media type or you won't be able to "know" what the URL is to create issues.

@SleeplessByte SleeplessByte merged commit cb1d007 into master Oct 17, 2018
@SleeplessByte SleeplessByte deleted the feature/issues branch October 17, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees

@VincentRbbmnd VincentRbbmnd

Labels
💎 feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VincentRbbmnd @SleeplessByte