Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle waiting Auth data #8

Open
abs0 opened this issue Sep 16, 2017 · 0 comments
Open

Better handle waiting Auth data #8

abs0 opened this issue Sep 16, 2017 · 0 comments
Labels

Comments

@abs0
Copy link
Contributor

abs0 commented Sep 16, 2017

To try to better handle the following case

  • App starts, triggers OAuth2 on connected phone
  • User takes a while to login to TrainAsONE and click grant, so the app times out, garmin connect saves access code
  • User starts app again, we do not have a code so we trigger OAuth2 again
  • garmin connect return access code immediately registerForOAuthMessages is called, but we start OAuth2 process anyway
  • user sees the authorisation dialog a second time, even though they completed it last time, and clicking cancel will continue the app fine
@abs0 abs0 added the bug label Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant