Events #10
Merged
Events #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanjurman
reviewed
Jun 4, 2018
| const handleOnAttrSetter = element => prop => prop.key.slice(0, 2) === 'on' ? ![element[prop.key] = prop.value] : true | ||
| const handleNamespaceAttrSetter = (element, namespace) => prop => namespace ? ![element.setAttributeNS(null, prop.key, prop.value)] : true | ||
| const handleOnAttrSetter = element => prop => prop.key.slice(0, 2) === 'on' ? addEventToElement(element, prop.key, prop.value) || false : true | ||
| const handleNamespaceAttrSetter = (element, namespace) => prop => namespace ? element.setAttributeNS(null, prop.key, prop.value) || false : true |
There was a problem hiding this comment.
isn't this the same as
namespace || !element.setAttributeNS(null, prop.key, prop.value)also isn't A || false always going to be A? Or is this because it requires a boolean value even if undefined?
There was a problem hiding this comment.
Ahh, after reading the top a bit more I think I get some of the logic, I still feel like you should be watching how you are using A || false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is the first of an org-wide change to support events dynamically in Tram-One. This branches from Tram-One/tram-one#76
This change embeds a list of events into elements. They can then be accessed using the
.eventsproperty. This gives Tram-One access to the list of events bound to an element, which is not natively available on the element.Tests
A test has been added to verify that events are attached to the element. All tests pass locally.