Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/replace tab component #67

Merged
merged 5 commits into from
Jul 21, 2023
Merged

fix/replace tab component #67

merged 5 commits into from
Jul 21, 2023

Conversation

mvarlic
Copy link
Contributor

@mvarlic mvarlic commented Jul 20, 2023

  • replace tab with errors
  • replace all tables by divs

image

image
image

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@arturoflores03 arturoflores03 self-requested a review July 21, 2023 13:52
arturoflores03
arturoflores03 approved these changes Jul 21, 2023
View reviewed changes
Copy link

@arturoflores03 arturoflores03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mastudillot
mastudillot approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvarlic mvarlic merged commit 40b0a80 into master Jul 21, 2023
3 checks passed
@mvarlic mvarlic deleted the fix/replace-tab-component branch July 21, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastudillot mastudillot mastudillot approved these changes

@arturoflores03 arturoflores03 arturoflores03 approved these changes

@isabellaahc isabellaahc Awaiting requested review from isabellaahc

@victormendoza96 victormendoza96 Awaiting requested review from victormendoza96

@Matiasnickolas Matiasnickolas Awaiting requested review from Matiasnickolas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mvarlic @mastudillot @arturoflores03