Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: multiple cancellation #79

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: multiple cancellation #79

merged 2 commits into from
Jan 22, 2024

Conversation

mvarlic
Copy link
Contributor

@mvarlic mvarlic commented Jan 19, 2024

  • validate if the order is already canceled

image

image

@mvarlic mvarlic self-assigned this Jan 19, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 19, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

mastudillot
mastudillot approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@mastudillot mastudillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvarlic mvarlic merged commit f81936c into develop Jan 22, 2024
3 checks passed
@mvarlic mvarlic deleted the fix/multiple-cancellation branch January 22, 2024 19:29
isabellaahc
isabellaahc approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@isabellaahc isabellaahc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mastudillot mastudillot mentioned this pull request Jan 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabellaahc isabellaahc isabellaahc approved these changes

@tribiec tribiec tribiec approved these changes

@mastudillot mastudillot mastudillot approved these changes

@victormendoza96 victormendoza96 Awaiting requested review from victormendoza96

@Matiasnickolas Matiasnickolas Awaiting requested review from Matiasnickolas

Assignees

@mvarlic mvarlic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mvarlic @isabellaahc @tribiec @mastudillot