Feat/add default configs #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Webpay plus - Add the 'create' method under Webpay plus - Add a test template (To be implemented)
- Add the create action for WebpayPlus - Add tests - Refactor the HTTP client to make it more understandable and debuggable
- Remove the Mall\Transaction class because it was originally thought that it'd extend the WebpayPlus Transaction class and then override the methods that are different on Mall, however this is not possible because the method signatures are different, and this is not allowed on PHP
- Add default config methods for several types of Webpay transactions (Webpay Plus, Webpay plus mall, Webpay plus deferred) - Add the default commerce codes used for testing the aforementioned transaction types as constants
goncafa
suggested changes
Jul 9, 2019
There was a problem hiding this comment.
@eugenioLopezRamos You are asking to merge on master, rememeber we should merge in another branch while sdk is not complete.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.