Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of Fulib by A. Idani #9

Open
meeduse opened this issue Jul 5, 2019 · 0 comments
Open

Review of Fulib by A. Idani #9

meeduse opened this issue Jul 5, 2019 · 0 comments

Comments

@meeduse
Copy link

meeduse commented Jul 5, 2019

Positive points :

  1. Good performance
  2. All generated cases are covered

Negative points :

  1. Seems like a Java-based implementation of the transformation. The author mentions that expandLink, addColumn, and addRow are appropriate model transformations. However, they are also java methods. Note that I didn’t find the implementation of expandLink. My main question is: is the author evaluating the performances of a Java-based transformation ?
  2. Validation is done only via the validator jar file (no defined testing strategy)
  3. FulibSolution.java : more than 300 lines of java code with a poor documentation.
  4. What about truth tables with non-filled cells like that in the call for solutions document? How this solution could be evolved in order to cover this case?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant