Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionaility to use APT packages #1164

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

andrew-kelly-neutralaiz
Copy link
Contributor

Description

Re-submitting this PR due to an accidental pollution of commits into our fork. Wanted to make sure it was clean. Apologies I don't mean to waste time.

I need the ability to add some additional libraries outside of python itself as I wanted to create a tool for running headless chrome. That required a number of dependancies installed using the apt tool.

Related Issues

NA

Solution and Design

I duplicated what is done for pip installs and modified it for apt.

Test Plan

Include a file called /app/requirements_apt.txt, add the name of an apt package, monitor stack logs for successful installation of said package on docker compose up.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@luciferlinx101
Copy link
Collaborator

Hey @andrew-kelly-neutralaiz my only concern was supporting different operating systems like windows and macOS, can you bring support for other OS or handle it in such a way that it does not break in OS other than Linux based.

@Fluder-Paradyne
Copy link
Collaborator

Hey @andrew-kelly-neutralaiz my only concern was supporting different operating systems like windows and macOS, can you bring support for other OS or handle it in such a way that it does not break in OS other than Linux based.

since we use linux images
this shouldn't cause issues

@andrew-kelly-neutralaiz
Copy link
Contributor Author

Looks like Fluder-Paradyne has answered the concern. Thanks!

luciferlinx101
luciferlinx101 previously approved these changes Sep 6, 2023
@luciferlinx101 luciferlinx101 changed the base branch from main to dev September 6, 2023 05:31
@luciferlinx101 luciferlinx101 changed the base branch from dev to main September 6, 2023 05:31
@luciferlinx101 luciferlinx101 dismissed their stale review September 6, 2023 05:31

The base branch was changed.

@luciferlinx101 luciferlinx101 merged commit c15ded4 into TransformerOptimus:main Sep 6, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants