Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated external tool download path #608

Merged
merged 7 commits into from
Jul 3, 2023
Merged

Conversation

luciferlinx101
Copy link
Collaborator

@luciferlinx101 luciferlinx101 commented Jul 2, 2023

Description

  • Fixing minor bug of the download path in the tool manager
  • Fixed the tools.json key format for uniqueness.

Related Issues

Download path issue for external tool

Solution and Design

Fixed the download path hence add tool download at required path, tools.json have unique key

Test Plan

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@875d128). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 65f6c89 differs from pull request most recent head 57db520. Consider uploading reports for the commit 57db520 to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #608   +/-   ##
======================================
  Coverage       ?   54.95%           
======================================
  Files          ?      123           
  Lines          ?     4771           
  Branches       ?      503           
======================================
  Hits           ?     2622           
  Misses         ?     2043           
  Partials       ?      106           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TransformerOptimus TransformerOptimus merged commit e90c57f into dev Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants