Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/key authentication #792

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Fix/key authentication #792

merged 3 commits into from
Jul 18, 2023

Conversation

nihiragarwal24
Copy link
Collaborator

Description

Added a check to verify llm api keys

Solution and Design

Whenever a user comes to the app and saves their api keys, we will once verify their api keys by calling list_models api. If it doesn't work, it surely means its a bad key

Test Plan

Tried it with bogus and verified keys. It worked perfectly.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs update

Checklist

  • My pull request is atomic and focuses on a single change.
  • I have read the contributing guide and my code conforms to the guidelines.
  • I have documented my changes clearly and comprehensively.
  • I have added the required tests.

@Fluder-Paradyne Fluder-Paradyne merged commit d9c29fd into main Jul 18, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants