Adds a shortest_name_length value to the synonyms file
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
This code has now been moved into PR #166, and so is not needed here. Closing. |
gaurav
added a commit
that referenced
this pull request
Jul 25, 2023
Something in the NCBIGene synonym generation code has resulted in just about every NCBIGene being assigned the synonym `-` -- this is because `gene_info.gz` uses `-` to indicate an empty value, but our current code assumes that is a synonym. Fixed by adding a helper function to replace `-` with the empty string, and explicitly ignoring any synonym that is an empty string. In addition to that fix, this PR: 1. Replaces the `ftp://` URL used to download UniProtKB with an `https://` URL to speed up the download a little. 2. Cleans up some code around synonym list generation. 3. Restores the `shortest_name_length` calculation that we used previously to sort NameRes results (from PR #159). 4. Increases the space stored in Babel file systems (from PR #162).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the previously used sorting method as per TranslatorSRI/NameResolution#65 (comment).
WIP