Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests and index-wide tests #112

Open
gaurav opened this issue Nov 11, 2023 · 1 comment
Open

Add integration tests and index-wide tests #112

gaurav opened this issue Nov 11, 2023 · 1 comment

Comments

@gaurav
Copy link
Contributor

gaurav commented Nov 11, 2023

There are currently three types of tests for NameRes:

  1. Unit tests in this GitHub repository, which use a tiny dataset to make sure that the searching is working at a simple level.
  2. Babel Validation has some Scala-based tests, but for NameRes it pretty much just reads through the file to make sure it's readable. We need more advanced testing, in particular index-wide tests that allow us to find cases where the same name is used for multiple concepts (Look for cases where the same synonym is mapped to multiple identifiers #40).
  3. The website tests in Babel Validation. Since a lot of these were developed in a hurry, they're pretty usable for me, but (1) aren't very easy for everybody to understand, and (2) aren't easy to set up and run.

This means there are two big gaps in the testing. Here's how I propose fixing them:

  1. Python-based integration tests, piggy-backing on the same data used by Babel Validation, but including other tests as well. This will make it easier to replicate the current Babel Validation tests, plus allow us to quickly write new tests for e.g. slow-running terms (Slow performance with short words in search query #107) and to prove that we can provide the throughput that Translator needs (.
  2. Write some index-wide tests. This will probably make more sense to create in the Babel Validation repository. Our last plan there was to write them in Souffle, and I'm not sure there is a better way to implement them.

This also applies to NameRes (#113).

@gaurav
Copy link
Contributor Author

gaurav commented Dec 3, 2023

Python tests were added to babel-validation in PR TranslatorSRI/babel-validation#25. I'll tackle index-wide tests next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant