Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokenization #33

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Tokenization #33

merged 2 commits into from
Jan 18, 2023

Conversation

cbizon
Copy link
Contributor

@cbizon cbizon commented Dec 14, 2022

This replaces the fragment creation in server to effectively treat punctuation as " " rather than "". So "beta-secretase" becomes "beta secretase" rather than "betasecretase" for the purposes of searching. This better matches the tokenization that is occuring on load into solr.

@cbizon cbizon requested a review from gaurav December 14, 2022 19:52
Copy link
Contributor

@gaurav gaurav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaurav gaurav merged commit 13f00d7 into master Jan 18, 2023
@gaurav gaurav deleted the tokenization branch January 18, 2023 18:37
@gaurav
Copy link
Contributor

gaurav commented Jan 19, 2023

@cbizon This code is now up and running at http://name-resolution-sri-dev.apps.renci.org/docs, and "beta-secretase" now works as expected! I've updated https://name-resolution-sri.renci.org/docs as well now.

@cbizon
Copy link
Contributor Author

cbizon commented Jan 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants