Added a GitHub Action to build and publish NameRes Docker images in GitHub #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav
force-pushed
the
change-docker-to-use-current-code
branch
from
00338a9
to
536bf22
Compare
gaurav
changed the title
gaurav
force-pushed
the
change-docker-to-use-current-code
branch
from
379f757
to
7231356
Compare
gaurav
changed the title
gaurav
force-pushed
the
change-docker-to-use-current-code
branch
from
57a8409
to
24a2c4d
Compare
I'll update this again once the tarball has been generated.
Merged
cbizon
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a GitHub Action to build two Docker images for NameRes -- a
nameresolutionimage based on./Dockerfile, which can act as a web host for a correctly configured Solr database (see setup.sh for code on building this), and anameresolution-data-loadingimage based on the./data-loading/Dockerfile, which can be used to load a Solr database with the synonym files produced by Babel (after TranslatorSRI/Babel#113). You can see these Docker images at https://github.com/orgs/TranslatorSRI/packages?repo_name=NameResolutionAlso contains a minor bug fix: we now allow a document to be missing a preferred_name, names, curie or types field and provide blank output in that case.
Should be merged after PR #53.