Test NodeNorm #229 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added black so I can reformat the file.
cbizon
approved these changes
Nov 28, 2023
gaurav
added a commit
to TranslatorSRI/NodeNormalization
that referenced
this pull request
Dec 7, 2023
As reported in #229. As far as I can tell, this was caused by merged_binding being None, which could cause it to end up being an object later in the code. Handling the case where it's None appears to fix this problem as per the simple test in PR TranslatorSRI/babel-validation#26. Fixes #229.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for TranslatorSRI/NodeNormalization#229.
It also adds
blackto the requirements (so we can reformat Python files) and adds alocalhosttarget for local testing.