Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin Panel Scroll Issue & Core User's Organization Name Bug #314

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Admin Panel Scroll Issue & Core User's Organization Name Bug #314

merged 3 commits into from
Mar 22, 2022

Conversation

SiddharthBhansali13
Copy link

Purpose

  • Fix error form helper text color.
  • Fix scroll issue on accordions in admin panel.
  • Fix a bug which prevents a user's organization name to be populated after permission or active status update.

Ticket number

Closes #310 & #311.

@SiddharthBhansali13 SiddharthBhansali13 added the bug Something isn't working label Mar 21, 2022
@SiddharthBhansali13 SiddharthBhansali13 self-assigned this Mar 21, 2022
@SiddharthBhansali13 SiddharthBhansali13 linked an issue Mar 21, 2022 that may be closed by this pull request
Disable scroll on accordion in Admin Panel #311
Closed
2 tasks
RadhikaPPatel
RadhikaPPatel requested changes Mar 21, 2022
View reviewed changes
Copy link

@RadhikaPPatel RadhikaPPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

src/pages/UserManagement/Users/Users.js Show resolved Hide resolved
src/pages/UserManagement/Users/Users.js Show resolved Hide resolved
src/pages/UserManagement/Users/Users.js Show resolved Hide resolved
RadhikaPPatel
RadhikaPPatel approved these changes Mar 22, 2022
View reviewed changes
Copy link

@RadhikaPPatel RadhikaPPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yasmin2496 yasmin2496 merged commit 9dbe043 into master Mar 22, 2022
@yasmin2496 yasmin2496 deleted the bug#311/bug#310 branch March 22, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yasmin2496 yasmin2496 yasmin2496 approved these changes

@RadhikaPPatel RadhikaPPatel RadhikaPPatel approved these changes

Assignees

@SiddharthBhansali13 SiddharthBhansali13

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint-14-Mar to 25-Mar
3 participants
@SiddharthBhansali13 @yasmin2496 @RadhikaPPatel