Add dependency installer script #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KareemMAX
suggested changes
Jun 12, 2023
There was a problem hiding this comment.
Currently we have https://github.com/unifyai/builder/blob/master/docs/prebuild.sh, do you think we need to merge it with install_dependencies.sh?
The code for installing prebuilds(if available) is still present in the doc builder. But I think the best way would be it add the code for running this prebuilds inside installer scripts, that would make it more standard I guess and we only have to look into the installer script in the repo to know about the dependencies. Hope this is what you also meant 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the doc-builder installs the packages required for each project by going through if-else statements as there are slight changes in the commands used for each project. Adding install_dependencies.sh script will allow the doc builder to generalise this process by having to just look for this script in the project directory.
The PR is related to the below task:
https://trello.com/c/VG4SYszL