Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta.py<_train_tasks_batched #22628

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

MahadShahid8
Copy link
Contributor

Added the helpful doc string for better understanding of the function

PR Description

Added the doc string to the respective function for better understanding of the code

Related Issue

Close #22627

Checklist

  • Did you add a function?
  • Did you add the tests?
  • [ ]Yes Did you follow the steps we provided?

Socials:

Added the helpful doc string for better understanding of the function
@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@MahadShahid8
Copy link
Contributor Author

@ndurumo254 kindly review my pull request

@MahadShahid8
Copy link
Contributor Author

@ndurumo254 kindly review my pr as soon as you can

@MahadShahid8
Copy link
Contributor Author

@ndurumo254

2 similar comments
@MahadShahid8
Copy link
Contributor Author

@ndurumo254

@MahadShahid8
Copy link
Contributor Author

@ndurumo254

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MahadShahid8
Thanks for the PR and for your contribution. And sorry for delay on our end. :)
If you could add an example in a separate PR you are welcome. I will merge this right now anyways.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@Ishticode Ishticode merged commit 0c3f719 into Transpile-AI:main Feb 27, 2024
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<_train_tasks_batched>
4 participants