Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct tensorflow avg pool2d test failure #26116

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

adityadeshmukh369
Copy link
Contributor

@adityadeshmukh369 adityadeshmukh369 commented Sep 26, 2023

PR Description

Fixes #25928
Fixes failing test cases for tensorflow_avg_pool2d

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@adityadeshmukh369 adityadeshmukh369 changed the title Fix : Resolved test cases nn.test_tensorflow_avg_pool2d Fix : nn.test_tensorflow_avg_pool2d Sep 26, 2023
@adityadeshmukh369 adityadeshmukh369 changed the title Fix : nn.test_tensorflow_avg_pool2d Fix : correct tensorflow avg pool2d test failure Sep 26, 2023
@adityadeshmukh369 adityadeshmukh369 changed the title Fix : correct tensorflow avg pool2d test failure Fix: correct tensorflow avg pool2d test failure Sep 26, 2023
@adityadeshmukh369 adityadeshmukh369 changed the title Fix: correct tensorflow avg pool2d test failure fix: correct tensorflow avg pool2d test failure Sep 26, 2023
@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Sep 26, 2023
@adityadeshmukh369
Copy link
Contributor Author

@RickSanchezStoic can you review the PR ?

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adityadeshmukh369
Thank you very much for the PR. Apologies for the delays on our end.
This should have been merged earlier as it fixes value mismatches issue.
I will merge it by the end of today. Thanks a lot for your contribution. :)

@Ishticode Ishticode merged commit 782e745 into Transpile-AI:main Feb 29, 2024
231 of 293 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix nn.test_tensorflow_avg_pool2d
6 participants