index_add_

[imsoumya18]

PR Description

index_add_ method in Paddla FrontEnd

Related Issue

index_add_ #26393

Close #26393

Checklist

• Did you add a function?
• Did you add the tests?
• Did you run your tests and are your tests passing?
• Did pre-commit not fail on any check?
• Did you follow the steps we provided?

Socials

Twitter

[github-actions]

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

• docs: correct typo in README
• feat: implement dark mode"
• fix: correct remove button behavior

Linting Errors

• Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
• No subject found

[github-actions]

Thank you for this PR, here is the CI results:

---

This pull request does not result in any additional test failures. Congratulations!

[hello-fri-end]

Hey @imsoumya18 ! Thanks for taking the time to work on this. Actually, we have a policy for keeping the frontend implementations short and this implementation is 25 lines long and there are 3 nested while loops in the code. Ideally, the frontend implementations should only contain a few lines. Therefore, I would advice you to first create an issue in our repo for adding the index_add function to ivy's functional API using this template guide. A memeber of our team will team review the request and add it to an open task. Then it's your choice, if you want to take it up yourself and wait for someelse else to pick it up. Otherwise, if you feel there's a way of making the frontend implementation short without adding this function to our functional API, I'd be happy to discuss the approach with you as well. Thanks !

[imsoumya18]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

[NiteshK84]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18,
Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

[NiteshK84]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API?

as per the policy, we will have to update your previous function implementation as well.

[imsoumya18]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

I tried that. But, other devs didn't merge that saying a new functional API is unnecessary for such small reason and gave a green signal to go forward with this approach. That's why this is stuck for a long time. I'll try to pass the tests and let u know.

[NiteshK84]

@NiteshK84 can u please have a look at it? Same as #26394 but, in place version.

Hi @imsoumya18, Could you kindly start by initiating the creation of a new issue for incorporating the index_add function into the IvyFunctional API as suggested by @hello-fri-end ?

I tried that. But, other devs didn't merge that saying a new functional API is unnecessary for such small reason and gave a green signal to go forward with this approach. That's why this is stuck for a long time. I'll try to pass the tests and let u know.

If that is the case, then you can sure go forward and work on fixing the remaining failing test cases.

[imsoumya18]

@NiteshK84 all tests passed !!

[imsoumya18]

@NiteshK84 all tests are passing now. Have a look at it...

[NiteshK84]

LGTM!