Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ivy.index_add #26801

Open
imsoumya18 opened this issue Oct 9, 2023 · 2 comments
Open

ivy.index_add #26801

imsoumya18 opened this issue Oct 9, 2023 · 2 comments
Assignees
@Infrared1029
Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task

Comments

@imsoumya18
Copy link
Contributor

imsoumya18 commented Oct 9, 2023 •
edited
Loading

Why should this be implemented?

  • it's needed for a complex/long frontend function implementation
  • Also, it will solve the problem for index_add_ , which is the in-place version of this

Links to native framework implementations
@imsoumya18 imsoumya18 added Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task labels Oct 9, 2023
@imsoumya18
Copy link
Contributor Author

hi @Infrared1029 I created a PR #26761 for adding index_add_ and got the review (#26761 (review)) instead of writing such long code, implement it in Ivy functional API first and then call whenever needed.

So, I have created the issue. Can you please guide me on where to write in the codebase?

I couldn't find you on the Discord server. My ID: imsoumya18 on Discord

imsoumya18 added a commit to imsoumya18/ivy that referenced this issue Oct 12, 2023
@imsoumya18
ivy.index_add issue ivy-llc#26801
eb4ba51
@imsoumya18 imsoumya18 mentioned this issue Oct 12, 2023
Closed
5 tasks
@imsoumya18
Copy link
Contributor Author

Hi @Infrared1029 I would request you to add this as ToDo in #3856

@imsoumya18 imsoumya18 mentioned this issue Oct 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Infrared1029 Infrared1029

Labels
Ivy API Experimental Run CI for testing API experimental/New feature or request Next Release This issue or PR should only be considered once the next release is out. Suggestion A suggestion rather than a detected issue or a definitive task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ivy.index_add imsoumya18/ivy
2 participants
@imsoumya18 @Infrared1029